Re: [RFC PATCH v2 12/16] Smart fetch and push over HTTP: server side

Johannes Sixt [off-list ref] wrote:

Shawn O. Pearce schrieb:

quoted

diff --git a/http-backend.c b/http-backend.c

#include "run-command.h" is missing here because you added it already in
patch 10/16 unnecessarily.

quoted

+	if (start_command(&cld))
+		die_errno("Cannot start %s", argv[0]);
...
+	if (finish_command(&cld))
+		die("%s terminated with error", argv[0]);

start_command and finish_command already write an error message for you
that includes argv[0] and errno. You can just exit(1) here.

Whoops on both; thanks for the catch.

-- 
Shawn.