Re: [RFC PATCH v2 12/16] Smart fetch and push over HTTP: server side
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:47:32
Shawn O. Pearce schrieb:
quoted hunk ↗ jump to hunk
diff --git a/http-backend.c b/http-backend.c index 39cfd25..adb3256 100644 --- a/http-backend.c +++ b/http-backend.c
#include "run-command.h" is missing here because you added it already in patch 10/16 unnecessarily.
+ if (start_command(&cld))
+ die_errno("Cannot start %s", argv[0]);
...
+ if (finish_command(&cld))
+ die("%s terminated with error", argv[0]);start_command and finish_command already write an error message for you that includes argv[0] and errno. You can just exit(1) here. -- Hannes