Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH 1/2] Add date formatting and parsing functions relative to a given time

From: Jeff King <hidden>
Date: 2016-06-15 22:47:20

On Fri, Aug 28, 2009 at 11:04:04PM +0200, Alex Riesen wrote:
+const char *show_date_relative(unsigned long time, int tz, const struct timeval *now)
+{
+	static char timebuf[100 /* TODO: can be optimized */];
This was 200 in the original version. I doubt that it makes a
difference, but I think in a refactoring patch I think it is best to
simply reorganize and make no other changes.
+static unsigned long approximation(const char *date, const struct timeval *tv)
I know it's static, but this is a terribly undescriptive function name.
Approximation of what?  Can we call it approxidate_internal or
something?

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help