Thread (19 messages) flat view 19 messages, 3 authors, 2016-06-15

Re: [RFC PATCH v2 4/4] read-tree: add --no-sparse to turn off sparse hook

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:13

Nguyen Thai Ngoc Duy [off-list ref] writes:
quoted
Hmm.  I understand that the assumption is that memset(&opts, 0,
sizeof(opts)); should give you a sensible default, but I cannot avoid
noticing that "no_sparse_hook = 0" is a double negation, something to be
avoided...
skip_sparse_hook then? :-)
Why not making the hook to be skipped by default, and pass an explicit
option to trigger the hook?

I like Dscho's other suggestion to use patterns like .gitignore instead of
using hook scripts that needs to be ported across platforms, by the way.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help