Re: [PATCH] fix potential infinite loop given large unsigned integer
From: Tony Finch <dot@dotat.at>
Date: 2016-06-15 22:47:13
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] fix potential infinite loop given large unsigned integer · Ryan Flynn <hidden>
On Sun, 9 Aug 2009, Junio C Hamano wrote:
+ if (numbered) {
+ static char num_buf[64];
rev.total = total + start_number - 1;
+ sprintf(num_buf, "%d", rev.total);
+ rev.num_width = strlen(num_buf);
+ }
why not
if (numbered) {
rev.total = total + start_number - 1;
rev.num_width = snprintf(NULL, 0, "%d", rev.total);
}
?
Tony.
--
f.anthony.n.finch [off-list ref] http://dotat.at/
GERMAN BIGHT HUMBER: SOUTHWEST 5 TO 7. MODERATE OR ROUGH. SQUALLY SHOWERS.
MODERATE OR GOOD.