Re: [PATCH] fix potential infinite loop given large unsigned integer

On Sunday 09 August 2009, Erik Faye-Lund wrote:

On Sun, Aug 9, 2009 at 9:38 AM, Junio C Hamano[off-list ref] wrote:

quoted

+               static char num_buf[64];
               rev.total = total + start_number - 1;
+               sprintf(num_buf, "%d", rev.total);
+               rev.num_width = strlen(num_buf);

how about
rev.num_width = (int)log10((double)rev.total) + 1;

hm?

log10() appears to be C99, but can be emulated on earlier C-versions by
doing #define log10(x) (log(x) / log(10.0))

That would mean linking with -lm?

Regards,
Christian.