Re: [PATCHv7 0/9] gitweb: avatar support
From: Jakub Narebski <hidden>
Date: 2016-06-15 22:47:00
On Sat, 27 Jun 2009, Giuseppe Bilotta wrote:
One more attempt at adding avatar support to gitweb. The most significant change since the previous iteration is the addition of a picon provider, and its use as default from gravatar. Most other patches were changed to follow Jakub's suggestions. In particular, the two-line author/committer information was refactored to reduce code duplication, with the benefit that it could also be used in 'tag' view. Giuseppe Bilotta (9): gitweb: refactor author name insertion gitweb: uniform author info for commit and commitdiff gitweb: use git_print_authorship_rows in 'tag' view too gitweb: right-align date cell in shortlog gitweb: (gr)avatar support gitweb: gravatar url cache gitweb: picon avatar provider gitweb: use picon for gravatar fallback gitweb: add alt text to avatar img
I think this patch series shapes very nicely. A bit of refactoring upfront, so that the following patches are not very large, and don't need to repeat the same code in many places. Separate issues such as right-align date cell, or making 'commitdiff' view use authorship info layout from 'commit' view are put in separate patches in such way that they can be accepted or rejected individually. Very good work! -- Jakub Narebski Poland