Thread (29 messages) flat view 29 messages, 2 authors, 2016-06-15

Re: [PATCHv7 7/9] gitweb: picon avatar provider

From: Giuseppe Bilotta <hidden>
Date: 2016-06-15 22:47:00

2009/6/28 Jakub Narebski [off-list ref]:
Thoughts for the possible future enhancements: find final URL of an image
via http://www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/$domain/$user/users+domains+unknown/up/off/1/order
by scrapping (parsing) it for .gif link, and store this URL in cache.
But that most probably isn't worth it.  Just feel like mentioning it.
That was my first thought, but since piconsearch offers a link
directly, I decided it was much better to use that rather than html
scraping.
Should it be stated that <img width="$size" ...> is here because not
all kinds of avatars (not all avatar providers) support selecting size
of avatar, somewhere in this comment?
It is generally good form to have the size specified in advance in
HTML anyway, which is why on later iterations I put the width spec in
the first avatar service commit.

-- 
Giuseppe "Oblomov" Bilotta
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help