Re: [PATCH v2 1/2] compat: add a mkstemps() compatibility function

On Thu, May 28, 2009 at 09:07:32AM +0200, Johannes Sixt wrote:

David Aguilar schrieb:

You should not include "random" system headers, nor has mkstemps any
business deciding whether files are opened in binary mode. We are not
using O_BINARY anywhere else (except in compat/mingw.c). With the patch
below squashed in (I hope it won't be wrapped) you can add:

Tested-by: Johannes Sixt <redacted> (Windows)

to both your patches. And, yes, I like them :-)

-- Hannes

Thanks.
I'll squash these in and resend 1/2 in a moment.


-- 

	David