Thread (6 messages) flat view 6 messages, 4 authors, 2016-06-15

Re: [JGIT PATCH 8/6] Fix zero context insert and delete hunk headers to match CGit

From: Ferry Huberts (Pelagic) <hidden>
Date: 2016-06-15 22:46:42

3) We should have a convention like C Git for marking known breakages.
One option is FIXME, another it so go JUnit 4 and abuse the expected exception 
annotation (using it for declaring OK exceptions is pretty bad use anyway I think,
so we might use it for something better), or perhaps the @Ignore annotation which
is meant specifically for this and other cases. A FIXME can be implemented right
away.
standard pratice for junit would be to write a test case on what you would 
expect to be _correct_ behaviour. obviously that test would then fail.
it would be a know failure in the test suite. do not go ignoring it. it's 
better to keep being reminded that stuff doesn't work :-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help