Re: [JGIT PATCH 8/6] Fix zero context insert and delete hunk headers to match CGit

söndag 03 maj 2009 02:50:36 skrev Miles Bader [off-list ref]:

"Shawn O. Pearce" [off-list ref] writes:

quoted

  And here is that hack.  It just feels wrong to me that I need
  to subtract 1 from the Edit region's line numbers, *only* when
  context is 0, in order to get the same output as CGit.

A big comment saying "this may look a bit funny, but it's the standard's
fault: [text from std...]" might help salve the wound...

1) I agree. This need to be commented in the code.

2) Do we need to fix it? I.e. is there a problem or just two different results,
where one is correct, the other incorrect but harmless.

3) We should have a convention like C Git for marking known breakages.
One option is FIXME, another it so go JUnit 4 and abuse the expected exception 
annotation (using it for declaring OK exceptions is pretty bad use anyway I think,
so we might use it for something better), or perhaps the @Ignore annotation which
is meant specifically for this and other cases. A FIXME can be implemented right
away.

-- robin