[PATCH JGIT] Computation of average could overflow · Sohn, Matthias <hidden> · 2016-06-15
Re: [PATCH JGIT] Computation of average could overflow · Shawn O. Pearce <hidden> · 2016-06-15
[PATCH JGIT] Method invokes inefficient new String(String) constructor · Sohn, Matthias <hidden> · 2016-06-15
[PATCH JGIT] Method invokes inefficient Number constructor; use static valueOf instead · Sohn, Matthias <hidden> · 2016-06-15
[PATCH JGIT] Method ignores results of InputStream.skip() · Sohn, Matthias <hidden> · 2016-06-15
Re: [PATCH JGIT] Method ignores results of InputStream.skip() · Shawn O. Pearce <hidden> · 2016-06-15
[PATCH JGIT] Method ignores results of InputStream.skip() · Sohn, Matthias <hidden> · 2016-06-15
Re: [PATCH JGIT] Method invokes inefficient Number constructor; use static valueOf instead · Shawn O. Pearce <hidden> · 2016-06-15
Re: [PATCH JGIT] Method invokes inefficient new String(String) constructor · Shawn O. Pearce <hidden> · 2016-06-15

Re: [PATCH JGIT] Method invokes inefficient new String(String) constructor

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:46:40

"Sohn, Matthias" [off-list ref] wrote:

Using the java.lang.String(String) constructor wastes memory because the
object so constructed will be functionally
indistinguishable from the String passed as a parameter.  Just use the
argument String directly.

NAK.

Like the Long.valueOf() case this came up before:

http://thread.gmane.org/gmane.comp.version-control.git/113739/focus=113787
 
-- 
Shawn.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help