Re: Removing duplicated code between builtin-send-pack.c and transport.c

On Wed, Apr 22, 2009 at 02:06:22PM -0500, Andy Lester wrote:

Yes, exactly.  I was applying const to function parameters in builtin- 
send-pack.c, and discovered the duplication.  I sure don't want to patch 
twice if we don't need to.

So it sounds like what I'll do is start a send-pack.c and hoist out the 
common functions from builtin-send-pack.c and transport.c.

I don't know if that is quite appropriate. I think the point of moving
many of the duplicated functions into transport.c is that they are used
by other transports, like http. So probably the transport-agnostic ones
should stay in transport.c, and they should all get called in the same
way, no matter what the transport.

-Peff