Thread (7 messages) flat view 7 messages, 3 authors, 2016-06-15

Re: Removing duplicated code between builtin-send-pack.c and transport.c

From: Andy Lester <hidden>
Date: 2016-06-15 22:46:38

On Apr 22, 2009, at 2:03 PM, Jeff King wrote:
I think Andy was referring to (2), and I think that should be cleaned
up, as the different versions have a tendency to diverge. Probably
addressing (1) by moving send_pack() to transport.c makes sense as  
part
of the same cleanup.

Yes, exactly.  I was applying const to function parameters in builtin- 
send-pack.c, and discovered the duplication.  I sure don't want to  
patch twice if we don't need to.

So it sounds like what I'll do is start a send-pack.c and hoist out  
the common functions from builtin-send-pack.c and transport.c.

xoxo,
Andy

--
Andy Lester => andy@petdance.com => www.theworkinggeek.com => AIM:petdance
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help