Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH RFC3 05/13] send-email: Cleanup the usage text and docs a bit

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:36

Michael Witten [off-list ref] writes:
All usage text lines should be < 80 characters.

A port number in --smtp-server is no longer handled,
so the suggestion has been removed.
That makes it sound like there is a regression.

	require Net::SMTP;
	$smtp ||= Net::SMTP->new((defined $smtp_server_port)
				 ? "$smtp_server:$smtp_server_port"
				 : $smtp_server);

and because Net::SMTP is a subclass of IO::Socket::INET, I'd assume that
this use will accept smtp_server=there:submission when $smtp_server_port
is undef.
---in-reply-to=<identifier>::
+--in-reply-to=<message-id>::
Changes along this line in your patch looked sensible, except for the
"identity" one which is a bit iffy.

Other than that I think the patch is sane.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help