Re: [PATCH] Add custom memory allocator to MinGW and MacOS builds

Hi,

On Fri, 3 Apr 2009, Marius Storm-Olsen wrote:

quoted

The standard allocator on Windows is pretty bad prior to Windows Vista,
and nedmalloc is better than the modified dlmalloc provided with newer
versions of the MinGW libc.

Note that both Windows and MacOSX need to have an implementation of
strdup, which I added at the end of nedmalloc.c, to ensure that strdup
use the same heap. So, setting USE_NED_ALLOCATION = YesPlease will also
add this function reimplementation, unless you define
NEDMALLOC_DONT_OVERRIDE_STRDUP.

NedMalloc stats in Git
----------------------
  All results are the best result out of 3 runs. The
  benchmarks have been done on different hardware, so
  the repack times are not comparable.

  These benchmarks are all based on 'git repack -adf'
  on the Linux kernel.

  XP
  -----------------------------------------------
  MinGW               Threads  Total Time   Speed
  -----------------------------------------------
  3.4.2                  (1T)  00:12:28.422
  3.4.2     + nedmalloc  (1T)  00:07:25.437 1.68x

  3.4.5                  (1T)  00:12:20.718
  3.4.5     + nedmalloc  (1T)  00:07:24.809 1.67x

  4.3.3-tdm              (1T)  00:12:01.843
  4.3.3-tdm + nedmalloc  (1T)  00:07:16.468 1.65x

  4.3.3-tdm              (2T)  00:07:35.062
  4.3.3-tdm + nedmalloc  (2T)  00:04:57.874 1.54x

Wow!  That is impressive.

indeed, haven't time to test it myself currently tho :-( i hope
someone can confirm this massive performance boost and that this patch
makes it into msysgit very soon. thanks for the work :-)