Re: [PATCH 01/10] refs: add "for_each_bisect_ref" function

Hi,

On Fri, 27 Mar 2009, Christian Couder wrote:

Le jeudi 26 mars 2009, Johannes Schindelin a écrit :

quoted

On Thu, 26 Mar 2009, Michael J Gruber wrote:

quoted

Christian Couder venit, vidit, dixit 26.03.2009 08:48:

quoted

Le jeudi 26 mars 2009, Sverre Rabbelier a écrit :

quoted

A 10 patches series with no cover letter?

I am not a big fan of cover letters. Usually I prefer adding 
comments in the patches.

I'm sorry I have to say that, but your individual preferences don't 
matter. Many of us would do things differently, each in their own 
way, but people adjust to the list's preferences. It's a matter of 
attitude. So, please...

Actually, a better way to ask for a cover letter would have been to 
convince Christian.  So I'll try that.

Thanks.

As you know, I have been sending patches since nearly 3 years ago to 
this list. And it's only since a few weeks ago that I am asked to send 
cover letters...

Heh, I have the feeling that your patch series were much shorter, and did 
not have many revisions, until a few weeks ago ;-)

quoted

From the patch series' titles (especially when they are cropped due to 
the text window being too small to fit the indented thread), it is not 
all that obvious what you want to achieve with those 10 patches.

From recent discussions, I seem to remember that you wanted to have 
some cute way to mark commits as non-testable during a bisect, and I 
further seem to remember that Junio said that very method should be 
usable outside of bisect, too.

Well, we want to move "git bisect skip" code from shell (in 
"git-bisect.sh") to C. So this patch series does that by creating a new 
"git bisect--helper" command in C that contains the new code and using 
that new command in "git-bisect.sh".

Oh?  I _completely_ missed that.  And that's being one of the original 
Cc:ed persons...

quoted

Unfortunately, that does not reveal to me, quickly, what is the 
current state of affairs, and what you changed since the last time.

Yeah, I should have at least put something in the comment section of my 
first patch in this series.

No.  I would still have missed it.

The cover letter is outside of any patch, because it describes the purpose 
of the _whole_ patch series, not just one patch.

So, it would have been nice to get a heads-up that this is not your 
bisect-skip-a-whole-bunch-of-commits series, but a new animal.

This way, I decided I do not have time for something I do not need, and 
deleted it without having a look.

Ciao,
Dscho