Re: [PATCH 01/10] refs: add "for_each_bisect_ref" function

Le jeudi 26 mars 2009, Johannes Schindelin a écrit :

Hi,

On Thu, 26 Mar 2009, Michael J Gruber wrote:

quoted

Christian Couder venit, vidit, dixit 26.03.2009 08:48:

quoted

Le jeudi 26 mars 2009, Sverre Rabbelier a écrit :

quoted

A 10 patches series with no cover letter?

I am not a big fan of cover letters. Usually I prefer adding comments
in the patches.

I'm sorry I have to say that, but your individual preferences don't
matter. Many of us would do things differently, each in their own way,
but people adjust to the list's preferences. It's a matter of attitude.
So, please...

Actually, a better way to ask for a cover letter would have been to
convince Christian.  So I'll try that.

Thanks.

As you know, I have been sending patches since nearly 3 years ago to this 
list. And it's only since a few weeks ago that I am asked to send cover 
letters...

From the patch series' titles (especially when they are cropped due to
the text window being too small to fit the indented thread), it is not
all that obvious what you want to achieve with those 10 patches.

From recent discussions, I seem to remember that you wanted to have some
cute way to mark commits as non-testable during a bisect, and I further
seem to remember that Junio said that very method should be usable
outside of bisect, too.

Well, we want to move "git bisect skip" code from shell (in "git-bisect.sh") 
to C. So this patch series does that by creating a new "git bisect--helper" 
command in C that contains the new code and using that new command 
in "git-bisect.sh".

Unfortunately, that does not reveal to me, quickly, what is the current
state of affairs, and what you changed since the last time.

Yeah, I should have at least put something in the comment section of my 
first patch in this series.

And I try to improve, you know, I even tried to use "git send-email" again 
this morning to see if perhaps I could use it to send my patch series.

I did:

$ git send-email --compose --dry-run bh15/*
Can't call method "repo_path" on an undefined value 
at /home/christian/libexec/git-core//git-send-email line 160.

and then I gave up, because I don't like spending a lot of my free time to 
fight with tools I don't like.

If someone knows some other tools that can easily send a threaded patch 
series, I will try to see if I can use them...

Thanks in advance,
Christian.