Re: [JGIT PATCH] Create a debugging tool "jgit rebuild-commitgraph"

Robin Rosenberg [off-list ref] wrote:

måndag 16 mars 2009 15:44:50 skrev "Shawn O. Pearce" [off-list ref]:

quoted

Robin Rosenberg [off-list ref] wrote:

quoted

I'd hate to put such a dangerous thing in the list of normal tools. If the user
want to shoot him/her-self in the foot they should get a license first.

How about squashing this in?

Does it have to be a utility accessible through the pgm interface? Why not 
just run ut as java org.spearce.jgit.pgm.debug.RebuildCommitGraph ? 

Yea, that's fine too.  Then its "debug-rebuildcommitgraph" I think,
but that's still a reasonable name for it.
 

quoted

 	@Override
 	protected void run() throws Exception {
+		if (!really && !db.getAllRefs().isEmpty()) {
+			final StringBuilder m = new StringBuilder();
+			m.append("fatal: ");

...

quoted

+			System.err.println(m);
+			throw die("Need approval to destroy current repository");

What's wrong with old fashioned '+' ? (which just translated to exactly this series
of StringBuilder calls anyway?

Nothing, other than formatting.  + line wraps somewhat ugly sometimes
under the Eclipse formatter.  Using StringBuilder with one append per
line and a short name for the StringBuilder variable makes it easier
to format.

-- 
Shawn.