Re: [JGIT PATCH] Create a debugging tool "jgit rebuild-commitgraph"
From: Robin Rosenberg <hidden>
Date: 2016-06-15 22:46:24
måndag 16 mars 2009 15:44:50 skrev "Shawn O. Pearce" [off-list ref]:
Robin Rosenberg [off-list ref] wrote:quoted
I'd hate to put such a dangerous thing in the list of normal tools. If the user want to shoot him/her-self in the foot they should get a license first.How about squashing this in?
Does it have to be a utility accessible through the pgm interface? Why not just run ut as java org.spearce.jgit.pgm.debug.RebuildCommitGraph ?
quoted hunk ↗ jump to hunk
diff --git a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RebuildCommitGraph.java b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RebuildCommitGraph.java index ccee997..cc23438 100644 --- a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RebuildCommitGraph.java +++ b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RebuildCommitGraph.java@@ -50,6 +50,7 @@ import java.util.Map; import org.kohsuke.args4j.Argument; +import org.kohsuke.args4j.Option; import org.spearce.jgit.errors.MissingObjectException; import org.spearce.jgit.errors.ObjectWritingException; import org.spearce.jgit.lib.Commit;@@ -85,6 +86,11 @@ * <p> */ class RebuildCommitGraph extends TextBuiltin { + private final String REALLY = "--destroy-this-repository"; + + @Option(name = REALLY, usage = "approve destruction of repository") + boolean really; + @Argument(index = 0, required = true, metaVar = "REFS", usage = "for-each-ref output") File refList;@@ -97,6 +103,30 @@ @Override protected void run() throws Exception { + if (!really && !db.getAllRefs().isEmpty()) { + final StringBuilder m = new StringBuilder(); + m.append("fatal: "); + m.append("This program will destroy the repository:"); + m.append("\n"); + m.append("fatal:\n"); + m.append("fatal: "); + m.append(db.getDirectory().getAbsolutePath()); + m.append("\n"); + m.append("fatal:\n"); + m.append("fatal: "); + m.append("To continue, add "); + m.append(REALLY); + m.append(" to the command line"); + m.append("\n"); + m.append("fatal:"); + System.err.println(m); + throw die("Need approval to destroy current repository");
What's wrong with old fashioned '+' ? (which just translated to exactly this series of StringBuilder calls anyway?
+ }
+ if (!refList.isFile())
+ throw die("no such file: " + refList.getPath());
+ if (!graph.isFile())
+ throw die("no such file: " + graph.getPath());
+
recreateCommitGraph();
detachHead();
deleteAllRefs();-- robin