Re: [JGIT PATCH] 1/2 : (reworked) Externalizable/Serializable Items

onsdag 18 februari 2009 22:48:59 skrev "Shawn O. Pearce" [off-list ref]:

Robin Rosenberg [off-list ref] wrote:

quoted

Shawn wrote:

quoted

quoted

+            os.writeUTF(KEY_FETCH);
+            os.writeUTF(refspec.toString());
+        }
+
+        for (RefSpec refspec : push) {
+        	os.writeUTF(KEY_PUSH);
+            os.writeUTF(refspec.toString());
+        }

Should we maybe allow RefSpec to serialize itself with
os.writeObject() rather than using writeUTF() directly?

Doesn't the style above make it easy to define and document
a format that is easy for non-java programs to write and read,
while writeObject introduces java-centric stuff (depending on
the full class name etc).

Non-Java reading a Java serialization stream?  Seriously?

No, that was my objection to using writeObject, as that make
it a Java-only stream, but then it might not be worth doing
it via the serialization mechanism.

-- robin