Thread (8 messages) flat view 8 messages, 5 authors, 2016-06-15

Re: [JGIT PATCH] 1/2 : (reworked) Externalizable/Serializable Items

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:46:14

Robin Rosenberg [off-list ref] wrote:
Shawn wrote:
quoted
quoted
+            os.writeUTF(KEY_FETCH);
+            os.writeUTF(refspec.toString());
+        }
+
+        for (RefSpec refspec : push) {
+        	os.writeUTF(KEY_PUSH);
+            os.writeUTF(refspec.toString());
+        }
Should we maybe allow RefSpec to serialize itself with
os.writeObject() rather than using writeUTF() directly?
Doesn't the style above make it easy to define and document
a format that is easy for non-java programs to write and read,
while writeObject introduces java-centric stuff (depending on
the full class name etc).
Non-Java reading a Java serialization stream?  Seriously?

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help