Thread (4 messages) flat view 4 messages, 4 authors, 2016-06-15

Re: [PATCH] Re: Minor grammar fix in the 'Not a git repository' message

From: Lars Noschinski <hidden>
Date: 2016-06-15 22:46:13

* Junio C Hamano [off-list ref] [09-02-17 01:51]:
Nicolas Sebrecht [off-list ref] writes:
quoted
The message
	"Not inside a git repository" 
of Wincent looks like the clearest and the fairest one.
I tend to agree.  I was only trying to see if we can salvage a more
precise diagnosis f66bc5f (Always show which directory is not a git
repository, 2008-12-22) tried to give users, but to do it throughly the
sentence will become even more awkward.

   "Not inside a bare git repository nor a work tree that has .git/ somewhere in it."
I think f66bc5f used the wrong path for the error message.
If the comment above this part of the code is accurate, cwd
is which should be belonging to a git repository, so I would suggest

     die("Not inside a git repository: %s", cwd)

  - Lars.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help