Re: [PATCH] Re: Minor grammar fix in the 'Not a git repository' message

Nicolas Sebrecht [off-list ref] writes:

The message
	"Not inside a git repository" 
of Wincent looks like the clearest and the fairest one.

I tend to agree.  I was only trying to see if we can salvage a more
precise diagnosis f66bc5f (Always show which directory is not a git
repository, 2008-12-22) tried to give users, but to do it throughly the
sentence will become even more awkward.

    "Not inside a bare git repository nor a work tree that has .git/ somewhere in it."

On Monday 16 February 2009 18:51:03 Junio C Hamano wrote:

Nicolas Sebrecht [off-list ref] writes:

quoted

The message
	"Not inside a git repository"
of Wincent looks like the clearest and the fairest one.

I tend to agree.  I was only trying to see if we can salvage a more
precise diagnosis f66bc5f (Always show which directory is not a git
repository, 2008-12-22) tried to give users.

"Not in a git repository or work tree: %s", DEFAULT_GIT_DIR_ENVIRONMENT
?
-- 
Boyd Stephen Smith Jr.                   ,= ,-_-. =.
bss@iguanasuicide.net                   ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy         `-'(. .)`-'
http://iguanasuicide.net/                    \_/

* Junio C Hamano [off-list ref] [09-02-17 01:51]:

Nicolas Sebrecht [off-list ref] writes:

quoted

The message
	"Not inside a git repository" 
of Wincent looks like the clearest and the fairest one.

I tend to agree.  I was only trying to see if we can salvage a more
precise diagnosis f66bc5f (Always show which directory is not a git
repository, 2008-12-22) tried to give users, but to do it throughly the
sentence will become even more awkward.

   "Not inside a bare git repository nor a work tree that has .git/ somewhere in it."

I think f66bc5f used the wrong path for the error message.
If the comment above this part of the code is accurate, cwd
is which should be belonging to a git repository, so I would suggest

     die("Not inside a git repository: %s", cwd)

  - Lars.

"Boyd Stephen Smith Jr." [off-list ref] writes:

On Monday 16 February 2009 18:51:03 Junio C Hamano wrote:

quoted

Nicolas Sebrecht [off-list ref] writes:

quoted

quoted

The message
	"Not inside a git repository"
of Wincent looks like the clearest and the fairest one.

I tend to agree.  I was only trying to see if we can salvage a more
precise diagnosis f66bc5f (Always show which directory is not a git
repository, 2008-12-22) tried to give users.

"Not in a git repository or work tree: %s", DEFAULT_GIT_DIR_ENVIRONMENT
?

"Not in a git repository or in a work tree: %s" perhaps...
cwd or DEFAULT_GIT_DIR_ENVIRONMENT?

-- 
Jakub Narebski
Poland
ShadeHawk on #git