Thread (15 messages) flat view 15 messages, 3 authors, 2016-06-15

Re: [PATCH 2/3] send-email: don't call unquote_rfc2047 unnecessarily

From: Jay Soffian <hidden>
Date: 2016-06-15 22:46:10

On Fri, Feb 13, 2009 at 10:51 PM, Jay Soffian [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Jay Soffian <redacted>

If --suppress-cc=author then there is no need to unquote the From:
address.

Signed-off-by: Jay Soffian <redacted>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index a2e0b94..2a3e3e8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -958,8 +958,8 @@ foreach my $t (@files) {
                               $subject = $1;
                       }
                       elsif (/^From:\s+(.*)$/) {
+                               next if $suppress_cc{'author'};
                               ($author, $author_encoding) = unquote_rfc2047($1);
-                               next if ($suppress_cc{'author'});
                               printf("(mbox) Adding cc: %s from line '%s'\n",
                                       $1, $_) unless $quiet;
                               push @cc, $1;
Crap. Ignore this one from the series. $author is used later and we
have to parse it regardless. This is brittle code, but I should've
realize it.

j.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help