Re: [PATCH] send-email: handle multiple Cc addresses when reading mbox message

On Fri, Feb 13, 2009 at 6:32 PM, Thomas Rast [off-list ref] wrote:

Jay Soffian wrote:

quoted

-                     if (/^(Signed-off-by|Cc): (.*)$/i) {
-                             next if ($suppress_cc{'sob'});

[...]

quoted

+             if (/^(Signed-off-by|Cc): (.*)$/i) {
+                     next if ($suppress_cc{'sob'});

Doesn't this actually look like a long-standing send-email bug?  Since
6564828 (git-send-email: Generalize auto-cc recipient mechanism.,
2007-12-25) they should go in separate categories, but the above lines
were just translated from the old $signed_off_cc setting.  It seems
they should distinguish between SOB and Cc.

I think it would be nice if send-email had different settings for
extracting Cc lines and extracting SOB lines from the message body,
but I don't call that a bug, but rather an enhancement request.

And yes, I noticed it when I went to send this patch because
originally I had "Cc: ..." in the commit message on column 0, which
send-email annoyingly picked up. I just changed my commit message to
move the "Cc:" to column 1.

Nonetheless, it is independent of this patch.

j.