Re: [PATCH] don't append 'opaquelocktoken:' in PUT and MOVE
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:07
Hi, On Sat, 7 Feb 2009, Tay Ray Chuan wrote:
quoted hunk ↗ jump to hunk
diff --git a/http-push.c b/http-push.c index eefd64c..10df94a 100644 --- a/http-push.c +++ b/http-push.c@@ -558,7 +558,7 @@ static void start_put(struct transfer_request *request) append_remote_object_url(&buf, remote->url, hex, 0); strbuf_addstr(&buf, "_"); - strbuf_addstr(&buf, request->lock->token); + strbuf_addstr(&buf, request->lock->token + 16);
Umm. This "16" is a little bit too hardcoded for my liking. I mean, it is not even obvious from _this_ hunk why "16" should be correct. Besides, I have to wonder where request->lock->token is set, and if that would not be the better place to fix the issue? Ciao, Dscho