Re: [PATCH] filter-branch: do not consider diverging submodules a 'dirty worktree'

Hi,

On Wed, 4 Feb 2009, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

As filter-branch could not care less about submodules' actual 
contents, it does not make sense to check if the checked-out 
submodules are up-to-date before running filter-branch.  So do not do 
it.

Sorry, but I am confused.  Is that because even the tree-filter does not 
use the actual work tree but works in the temporary area .git-rewrite, 
and a diverged submodule cannot possibly matter (and index-filter works 
solely on the index anyway)?

If so, why do we even check dirtiness of anything at all?

I guess it is because we could update the working directory with read-tree 
-u -m HEAD at the end.  Actually, that is exactly what we do.

Submodules do not matter much here, as nothing will be overwritten, 
really, but a dirty working directory matters.

Ciao,
Dscho