Re: [PATCH 2/3] git send-email: do not ask questions when --compose is used.

On Fri, Oct 31, 2008 at 09:33:38PM +0000, Ian Hilt wrote:

On Fri, Oct 31, 2008 at 01:36:48PM +0100, Pierre Habouzit wrote:

quoted

+GIT: Please enter your email below this line.

At first glance I thought this meant to enter my email address here.
So, instead of "email" would "message" be better?  Although on second
glance I realized this is where the body of the message went.  Not sure
if this is worth changing.

Well, this line sounds kind of awkward actually, so I was even thinking
about removing it.

Decent editors should probably have a plugin to put the cursor here and
be done with it.


In fact what looks odd is the GIT: stuff. a line looking like:

    --- write your message below this line ---

Looks 10x better, though need some code to strip it out if the user kept
it, and I'm lazy, GIT: stuff is automatically removed...


But if that's the only thing that you don't like in the series, I'm
glad, this is quite a minor issue ;)
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org