Thread (34 messages) flat view 34 messages, 5 authors, 2016-06-15
STALE3731d

[PATCH 1/3] git send-email: avoid leaking directory file descriptors.

From: Pierre Habouzit <hidden>
Date: 2016-06-15 22:45:33
Subsystem: the rest · Maintainer: Linus Torvalds

Signed-off-by: Pierre Habouzit <redacted>
---
 git-send-email.perl |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index bdbfac6..94ca5c8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -374,10 +374,9 @@ for my $f (@ARGV) {
 
 		push @files, grep { -f $_ } map { +$f . "/" . $_ }
 				sort readdir(DH);
-
+		closedir(DH);
 	} elsif (-f $f or -p $f) {
 		push @files, $f;
-
 	} else {
 		print STDERR "Skipping $f - not found.\n";
 	}
-- 
1.6.0.3.759.g40a2.dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help