Thread (7 messages) flat view 7 messages, 4 authors, 2016-06-15

Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:31

Possibly related (same subject, not in this thread)

Jeff King [off-list ref] writes:
On Wed, Oct 22, 2008 at 12:55:57AM +0400, Alexander Gavrilov wrote:
quoted
+test_expect_success \
+	'blame respects i18n.commitencoding' '
+	git blame --incremental file | \
+		grep "^\(author\|summary\) " > actual &&
+	test_cmp actual expected
Even though it is POSIX, using backslashed grouping in 'grep' isn't
portable. It fails at least on Solaris 8, and you have to do:

  egrep "^(author|summary) "

instead. Of course, I can't get your test to pass even with that change,
but I think that is just a broken iconv on Solaris.
Yuck.  Solaris 8 /usr/bin/grep does not even grok "-e", so we cannot do a
more obvious:

	grep -e "^author " -e "^summary "

Do people build with NO_EXTERNAL_GREP on older Solaris?

git-submodule.sh uses grep "-e" to look for two patterns and I suspect
older Solaris would have the same issue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help