Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.

On Wed, Oct 22, 2008 at 12:20 PM, Jeff King [off-list ref] wrote:

On Wed, Oct 22, 2008 at 12:55:57AM +0400, Alexander Gavrilov wrote:

quoted

+test_expect_success \
+     'blame respects i18n.commitencoding' '
+     git blame --incremental file | \
+             grep "^\(author\|summary\) " > actual &&
+     test_cmp actual expected

Even though it is POSIX, using backslashed grouping in 'grep' isn't
portable. It fails at least on Solaris 8, and you have to do:

 egrep "^(author|summary) "

instead. Of course, I can't get your test to pass even with that change,
but I think that is just a broken iconv on Solaris.

Hm, which of the conversions fail? You can try manually converting the
txt files with the iconv command to figure it out.

Alexander