Re: [PATCH (GITK) v2 3/4] gitk: Support filenames in the locale encoding.
From: Paul Mackerras <hidden>
Date: 2016-06-15 22:45:28
Alexander Gavrilov writes:
The previous patch changed the encoding used for reading diffs to binary, which broke non-ASCII filename support. This one fixes the breakage, together with some existing bugs related to filename encoding.
Sounds like this patch should be combined with the previous one.
quoted hunk ↗ jump to hunk
@@ -6250,11 +6250,12 @@ proc gettreeline {gtf id} { set line [string range $line 0 [expr {$i-1}]] if {$diffids ne $nullid2 && [lindex $line 1] ne "blob"} continue set sha1 [lindex $line 2] - if {[string index $fname 0] eq "\""} { - set fname [lindex $fname 0] - } lappend treeidlist($id) $sha1 } + if {[string index $fname 0] eq "\""} { + set fname [lindex $fname 0] + }
Concerning this part of the change, do we know whether git ls-files will quote filenames containing special characters or not? Paul.