Thread (12 messages) flat view 12 messages, 2 authors, 2016-06-15

Re: [PATCH (GITK) v2 3/4] gitk: Support filenames in the locale encoding.

From: Paul Mackerras <hidden>
Date: 2016-06-15 22:45:28

I wrote:
quoted
@@ -6250,11 +6250,12 @@ proc gettreeline {gtf id} {
 	    set line [string range $line 0 [expr {$i-1}]]
 	    if {$diffids ne $nullid2 && [lindex $line 1] ne "blob"} continue
 	    set sha1 [lindex $line 2]
-	    if {[string index $fname 0] eq "\""} {
-		set fname [lindex $fname 0]
-	    }
 	    lappend treeidlist($id) $sha1
 	}
+	if {[string index $fname 0] eq "\""} {
+	    set fname [lindex $fname 0]
+	}
Concerning this part of the change, do we know whether git ls-files
will quote filenames containing special characters or not?
A little experiment has convinced me that it does.  So this part looks
OK.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help