Re: [PATCH] git-submodule: remove unnecessary exits when calling resolve_relative_url

On Thursday 25 September 2008, Shawn O. Pearce wrote:

Johannes Sixt [off-list ref] wrote:

quoted

Did you test it? The command inside $(...) is run in its own
sub-process, therefore, the die() does not exit the caller, just
the sub-process, and the || exit *is* required.

BTW, I think that || exit is sufficient; you don't need to add
another error message - the one that resolve_relative_url() prints
is sufficient.

Exactly.

I think we just need a "|| exit" after each of these
$(resolve_relative_url) calls.  The original patch that
started this discussion just needs a "|| exit".

The original patch did exactly that: 
http://article.gmane.org/gmane.comp.version-control.git/96493


Have fun!

...Johan


-- 
Johan Herland, [off-list ref]
www.herland.net