Re: [PATCH] git-submodule: remove unnecessary exits when calling resolve_relative_url
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:45:24
David Aguilar schrieb:
resolve_relative_url calls die() when no remote url exists so these calls to exit can be removed.
...
quoted hunk ↗ jump to hunk
@@ -155,7 +155,7 @@ cmd_add() case "$repo" in ./*|../*) # dereference source url relative to parent's url - realrepo=$(resolve_relative_url "$repo") || exit + realrepo=$(resolve_relative_url "$repo") ;;
Did you test it? The command inside $(...) is run in its own sub-process, therefore, the die() does not exit the caller, just the sub-process, and the || exit *is* required. BTW, I think that || exit is sufficient; you don't need to add another error message - the one that resolve_relative_url() prints is sufficient. -- Hannes