Re: [PATCH v3] for-each-ref: `:short` format for `refname`

On Wed, Sep 3, 2008 at 18:33, Bert Wesarg [off-list ref] wrote:

On Wed, Sep 3, 2008 at 17:18, Shawn O. Pearce [off-list ref] wrote:

quoted

Bert Wesarg [off-list ref] wrote:

quoted

Try to shorten the refname to a non-ambiguous name.

Changes in v3:
 * don't compare sha1's, its ambiguous if the short name
   resovles to more than one ref
 * use xstrdup()
 * use indexes for the loops to clarify backward/forward
   direction


Signed-off-by: Bert Wesarg <redacted>
Cc: git@vger.kernel.org
Cc: szeder@ira.uka.de
Cc: Shawn O. Pearce <redacted>
---

Looks good.  But the commit messages shouldn't have the "Changes
in v3" section or probably the "Cc:" lines.  The changes in v3
part usually goes below the ---.

Ok, but shouldn't git format-patch detect that there is already a ---
in the commit message, or is it illegal to have more than one ---?

And while we are at it, shouldn't git format-patch detect, that there
is already a [*PATCH*]-prefix in the first line of the commit?

Ok, I was too fast, -k is obviously the right option for this.

I always need to edit these two things after format-patch.

Bert

quoted

--
Shawn.