Thread (15 messages) flat view 15 messages, 4 authors, 2016-06-15

Re: [PATCH 0/3] Enable parallelized tests

From: Stephan Beyer <hidden>
Date: 2016-06-15 22:45:07

Hi,
There are a few tests involving http transfers, namely:
  t5540-http-push.sh
  t9115-git-svn-dcommit-funky-renames.sh 
  t9118-git-svn-funky-branch-names.sh
  t9120-git-svn-clone-with-percent-escapes.sh

These start an apache web server at the beginning of the test and shut
it down after the test finished.  Obviously, if you run tests in
parallel then these tests can also run concurrently.  The problem is
with the svn tests, as all those tests use the same directory and port
for the web server, resulting in failed tests with -jN.

t5540 is not an issue at the moment, as it uses lib-httpd.sh, hence a
different directory and a (possibly) different port than the svn
tests.  However, who knows, in the future we might have other tests
using lib-httpd.sh.

The simplest solution would be to disable parallel testing altogether
if http tests are enabled (GIT_TEST_HTTPD and SVN_HTTPD_PORT).
Hm, another simple(?) solution could be to make the tests that try to
access the same port/directory/whatever depend on each other.
Well, this could bloat the Makefile, but seems to be clean (at least to
me).

Regards,
  Stephan

-- 
Stephan Beyer [off-list ref], PGP 0x6EDDD207FCC5040F
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help