Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] Add NO_RSYNC to allow building without rsync

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:05

Aidan Van Dyk [off-list ref] writes:
This is similar to NO_CURL.
I am not sure if this is a good change.

We link with libcurl so supporting NO_CURL makes sense for an environment
without the library, but for rsync transport we just spawn it as a
separate process.  The net effect on a machine without rsync installed is
the same (you cannot use rsync transport), but you can later choose to
install rsync and things will start working without recompiling git.
Signed-off-by: Aidan Van Dyk <redacted>
---

I came about this because SCO OpenServer doesnt' have mkdtemp.  But I never use
rsync, so making it optional was an easy fix.
Perhaps "make NO_MKDTEMP=YesPlease" is a much better fix for your
particular environment?

The patch is seriously whitespace damaged, in any case.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help