Re: [PATCH] Add NO_RSYNC to allow building without rsync

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Add NO_RSYNC to allow building without rsync

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:05

Aidan Van Dyk [off-list ref] writes:
This is similar to NO_CURL.
I am not sure if this is a good change.

We link with libcurl so supporting NO_CURL makes sense for an environment
without the library, but for rsync transport we just spawn it as a
separate process.  The net effect on a machine without rsync installed is
the same (you cannot use rsync transport), but you can later choose to
install rsync and things will start working without recompiling git.
Signed-off-by: Aidan Van Dyk <redacted>
---

I came about this because SCO OpenServer doesnt' have mkdtemp.  But I never use
rsync, so making it optional was an easy fix.
Perhaps "make NO_MKDTEMP=YesPlease" is a much better fix for your
particular environment?

The patch is seriously whitespace damaged, in any case.

Re: [PATCH] Add NO_RSYNC to allow building without rsync

From: Aidan Van Dyk <hidden>
Date: 2016-06-15 22:45:05

* Junio C Hamano [off-list ref] [080730 16:11]:
quoted
I came about this because SCO OpenServer doesnt' have mkdtemp.  But I never use
rsync, so making it optional was an easy fix.
Perhaps "make NO_MKDTEMP=YesPlease" is a much better fix for your
particular environment?
Yes, I found that out after...
The patch is seriously whitespace damaged, in any case.
Ooops... copy-n-paste from git-format-patch|more on some crappy sco terminal
through a screen session...  I guess someone in there translated tabs to
spaces...

a.

-- 
Aidan Van Dyk                                             Create like a god,
aidan@highrise.ca                                       command like a king,
http://www.highrise.ca/                                   work like a slave.

Re: [PATCH] Add NO_RSYNC to allow building without rsync

From: Boyd Lynn Gerber <hidden>
Date: 2016-06-15 22:45:05

On Wed, 30 Jul 2008, Aidan Van Dyk wrote:
* Junio C Hamano [off-list ref] [080730 16:11]:
quoted
quoted
I came about this because SCO OpenServer doesnt' have mkdtemp.  But I never use
rsync, so making it optional was an easy fix.
Perhaps "make NO_MKDTEMP=YesPlease" is a much better fix for your
particular environment?
Yes, I found that out after...
quoted
The patch is seriously whitespace damaged, in any case.
Ooops... copy-n-paste from git-format-patch|more on some crappy sco terminal
through a screen session...  I guess someone in there translated tabs to
spaces...
I do have rsync.  I use it all the time on OpenServer 6.  I have automated 
rsync backups of certain Openserver 6 machines.

tech0 > rsync --version
rsync  version 3.0.2  protocol version 30
Copyright (C) 1996-2008 by Andrew Tridgell, Wayne Davison, and others.
Web site: http://rsync.samba.org/
Capabilities:
    64-bit files, 64-bit inums, 32-bit timestamps, 64-bit long ints,
    socketpairs, hardlinks, symlinks, no IPv6, batchfiles, inplace,
    append, ACLs, no xattrs, iconv, no symtimes

tech0.zenez.com and osr600.zenez.com are OpenServer 6 machines.

--
Boyd Gerber [off-list ref]
ZENEZ	1042 East Fort Union #135, Midvale Utah  84047
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help