Re: [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path)

On Jul 29, 2008, at 1:13 PM, Johannes Schindelin wrote:

On Tue, 29 Jul 2008, Steffen Prohaska wrote:

quoted

On Jul 29, 2008, at 7:42 AM, Junio C Hamano wrote:

quoted

 We prefer running the dashless form, and POSIX side already does  
so;
 we should use it in MinGW's start_command(), too.

Thanks for reading my mind ;-)  This was the alternative  
justification I
had in mind after reading my patch again.

Well, given that the justification you gave had the obvious flaw --  
which
you even pointed out -- that non-builtins are _still_ affected, i.e.  
that
you leave that bug unfixed (but your description purports that you  
want to
fix that bug), it would have been wiser to give the alternative
justification, which makes the commit obviously correct.

We still need to fix the problem with system_path(), because currently
we cannot release Git-1.6.0 on Windows.  That is why I pointed out the
real problem we are facing.  The (good) side-effect is that the
MSYS-codepath is now prepared for 1.7.

	Steffen