Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path)

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:45:04

Hi,

On Tue, 29 Jul 2008, Steffen Prohaska wrote:
On Jul 29, 2008, at 7:42 AM, Junio C Hamano wrote:
quoted
  We prefer running the dashless form, and POSIX side already does so; 
  we should use it in MinGW's start_command(), too.
Thanks for reading my mind ;-)  This was the alternative justification I 
had in mind after reading my patch again.
Well, given that the justification you gave had the obvious flaw -- which 
you even pointed out -- that non-builtins are _still_ affected, i.e. that 
you leave that bug unfixed (but your description purports that you want to 
fix that bug), it would have been wiser to give the alternative 
justification, which makes the commit obviously correct.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help