Thread (31 messages) flat view 31 messages, 5 authors, 2016-06-15

Re: [PATCH 1/9] builtin-verify-tag.c: use parse_options()

From: Olivier Marin <hidden>
Date: 2016-06-15 22:45:00

Michele Ballabio a écrit :
 	if (argc == 1)
-		usage(builtin_verify_tag_usage);
+		usage_with_options(builtin_verify_tag_usage, options);
It seems this is broken since the C rewrite: "git verify-tag -v" just do
nothing instead of printing usage message.

Moving the if() after parse_options() call with s/argc == 1/argc == 0/
should do the trick.
-	if (!strcmp(argv[i], "-v") || !strcmp(argv[i], "--verbose")) {
-		verbose = 1;
-		i++;
-	}
+	argc = parse_options(argc, argv, options, builtin_verify_tag_usage, 0);
Olivier.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help