Thread (7 messages) flat view 7 messages, 2 authors, 2016-06-15

Re: [PATCH/RFC] git add: do not add files from a submodule

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:44:59

Hi Junio,

On Mon, 21 Jul 2008, Johannes Schindelin wrote:
It comes quite as a surprise to an unsuspecting Git user that calling
"git add submodule/file" (which is a mistake, alright) _removes_
the submodule in the index, and adds the file.  Instead, complain loudly.

While at it, be nice when the user said "git add submodule/" which is
most likely the consequence of tab-completion, and stage the submodule,
instead of trying to add the contents of that directory.
Do you plan to apply the split-up builtin-add enhancments you did a few 
nights ago, so that this patch can be elegant?  I think this fix should go 
into 1.6.0.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help