Re: [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:44:59
Hi, On Sat, 19 Jul 2008, Junio C Hamano wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin-add.c b/builtin-add.c index bf13aa3..9b2ee8c 100644 --- a/builtin-add.c +++ b/builtin-add.c[...] + /* + * If we are adding new files, we need to scan the working + * tree to find the ones that match pathspecs; this needs + * to be done before we read the index. + */
This comment left me scratching my head. While I do see a breakage when reading the index first, I had the impression that it should not. I can only imagine that the other users of read_directory() depend on some funny interaction between the index and treat_directory(). Ciao, Dscho