Re: [PATCH] Fixed text file auto-detection: treat EOF character 032 at the end of file as printable

Hi,

On Fri, 11 Jul 2008, Steffen Prohaska wrote:

On Jul 11, 2008, at 8:42 PM, Johannes Schindelin wrote:

quoted

On Fri, 11 Jul 2008, Steffen Prohaska wrote:

quoted

From: Dmitry Kakurin <redacted>

Signed-off-by: Dmitry Kakurin <redacted>
Signed-off-by: Steffen Prohaska <redacted>
---
convert.c |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/convert.c b/convert.c
index 352b69d..78efed8 100644
--- a/convert.c
+++ b/convert.c

@@ -61,6 +61,10 @@ static void gather_stats(const char *buf, unsigned long

size, struct text_stat *
 else
		stats->printable++;
}
+
+	/* If file ends with EOF then don't count this EOF as non-printable.
*/
+	if (size >= 1 && buf[size-1] == '\032')
+		stats->nonprintable--;

This is one of the things that are very specific to Windows and should not
affect other people.

Does this mean you are opposed to this change?

Hrm.  Thinking about it again, this _could_ help Unix people who 
collaborate with DOS people.

OTOH it will just hide the fact that text files were committed that 
contain silly characters.

On the third hand, this code path affects only people who set autocrlf.

Well, I guess they asked for it, kind of.

Ciao,
Dscho