Re: [PATCH] Fixed text file auto-detection: treat EOF character 032 at the end of file as printable
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:44:55
Hi, On Fri, 11 Jul 2008, Steffen Prohaska wrote:
quoted hunk ↗ jump to hunk
From: Dmitry Kakurin <redacted> Signed-off-by: Dmitry Kakurin <redacted> Signed-off-by: Steffen Prohaska <redacted> --- convert.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)diff --git a/convert.c b/convert.c index 352b69d..78efed8 100644 --- a/convert.c +++ b/convert.c@@ -61,6 +61,10 @@ static void gather_stats(const char *buf, unsigned long size, struct text_stat * else stats->printable++; } + + /* If file ends with EOF then don't count this EOF as non-printable. */ + if (size >= 1 && buf[size-1] == '\032') + stats->nonprintable--;
This is one of the things that are very specific to Windows and should not affect other people. Ciao, Dscho P.S.: this is one of the examples why I would like to discuss things that are Windows-only on the msysGit list, until we have a consensus there. We have a few Git experts there, you and Hannes in particular, which cover that side, but also some Windows experts such as Peter and Marius, and we should not need to have that discussion on a list where people are not expected to care about Windows _at all_.