Re: [PATCH] bash: offer only paths after '--'

Junio C Hamano [off-list ref] wrote:

SZEDER Gábor [off-list ref] writes:

quoted

Hope that I got the commit message right (;

It was very readable.  Thanks.

Acked-by: Shawn O. Pearce <redacted>

quoted

+__git_has_doubledash ()
+{
+	local c=1
+	while [ $c -lt $COMP_CWORD ]; do
+		if [ "--" = "${COMP_WORDS[c]}" ]; then
+			return 0
+		fi
+		c=$((++c))

This assignment is somewhat curious, although it should work as expected
either way ;-)

I agree, its damned odd.  But we already do this in the same
sort of loop inside of _git_branch() (see around line 541 in
next).  This new patch is only sticking with our current set
of conventions in the script, so I say its fine.

-- 
Shawn.