Re: Teach git-bundle to read revision arguments from stdin like git-rev-list
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:53
Adam Brewster [off-list ref] writes:
quoted hunk ↗ jump to hunk
@@ -227,8 +228,16 @@ int create_bundle(struct bundle_header *header, const char *path, /* write references */ argc = setup_revisions(argc, argv, &revs, NULL); - if (argc > 1) - return error("unrecognized argument: %s'", argv[1]); + + for (i = 1; i < argc; i++) { + if (!strcmp(argv[i], "--stdin")) { + if (read_from_stdin++) + die("--stdin given twice?");
Hmm, do we deeply care about this case? What bad things coulc happen if you call read_revisions_from_stdin() twice?
+ read_revisions_from_stdin(&revs);
+ continue;
+ }
+ return error("unrecognized argument: %s'", argv[i]);
+ }
for (i = 0; i < revs.pending.nr; i++) {
struct object_array_entry *e = revs.pending.objects + i;