Thread (14 messages) flat view 14 messages, 3 authors, 2016-06-15

Re: [PATCH] Move read_revisions_from_stdin from builtin-rev-list.c to revision.c

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:53

Miklos Vajna [off-list ref] writes:
I think it's fine to move such a function, but this is a false commit
message, you can use read_revisions_from_stdin() from builtin-bundle if
it lives in builtin-rev-list.c as well.
At the mechanical level, yes you _can_, but it is simply a bad taste to do
so.  More library-ish files such as revision.c are better home for utility
functions to be shared between builtins and commands.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help